On Wed, Oct 27, 2021 at 12:58 PM Richard Henderson < richard.hender...@linaro.org> wrote:
> On 10/27/21 9:09 AM, Warner Losh wrote: > > > > > >> On Oct 26, 2021, at 2:25 PM, Richard Henderson < > richard.hender...@linaro.org> wrote: > >> > >> On 10/26/21 3:22 AM, Alex Bennée wrote: > >>> +#else > >>> +#include "qemu.h" > >>> +#include "loader.h" > >> > >> There is no bsd-user/loader.h. > > > > Should there be? > > Probably. It came with Peter's cleanup of linux-user/qemu.h at > 3ad0a76928df01726e5872b8530d8e1eaa1a971d. > > What I meant with my over-terse response is that Alex's patch is > incomplete and cannot be > applied as-is. > > I think we should introduce a new header for sharing these new functions > with plugins/. > Perhaps something shared, in include/user/. > I like that idea. I think there'd need to be some level of effort to rework bsd-user to use a common header (though if it's just the header, not much). What's harder is sharing the bulk of the ELF loading code because it's the same everywhere. Or I should, sadly, say mostly the same everywhere but the 'mostly' can be worked out w/o a huge amount of fuss. Warner
