Based-on: <cover.1635036053.git.bala...@eik.bme.hu> ^ (hw/sh4: Codeing style fixes)
Continuing the clean up stared in previous series. This got big enough for now so I'll wait until these are merged (hopefully before the freeze) before going on so I don't have to carry them in my tree. Only plan to submit another version if needed from review otherwise that's it for now. v5: Do not use hw_error, back to qemu_log_mask; split up QOM-ify patch mode and drop one memory alias for sh_serial v4: Drop changes from fprintf before abort() as Philippe said, only change sh_serial now which can use hw_error instead; missed two more debug printfs in sh_timer that I've also added now; some more clean ups v3: Correct mistakes found in review, drop size change of sh_intc iomem as that was wrong so only rename it, more clean ups v2: separate sh_serial trace events, split QOM-ify patch for easier review and some more patches to clean up sh_intc a bit Regards, BALATON Zoltan (25): hw/sh4: Fix typos in a comment hw/sh4: Change debug printfs to traces hw/sh4/r2d: Use error_report instead of fprintf to stderr hw/char/sh_serial: Do not abort on invalid access hw/char/sh_serial: Rename type sh_serial_state to SHSerialState hw/char/sh_serial: Embed QEMUTimer in state struct hw/char/sh_serial: Split off sh_serial_reset() from sh_serial_init() hw/char/sh_serial: QOM-ify hw/char/sh_serial: Add device id to trace output hw/intc/sh_intc: Use existing macro instead of local one hw/intc/sh_intc: Turn some defines into an enum hw/intc/sh_intc: Rename iomem region hw/intc/sh_intc: Drop another useless macro hw/intc/sh_intc: Move sh_intc_register() closer to its only user hw/intc/sh_intc: Remove excessive parenthesis hw/intc/sh_intc: Use array index instead of pointer arithmetics hw/intc/sh_intc: Inline and drop sh_intc_source() function hw/intc/sh_intc: Replace abort() with g_assert_not_reached() hw/intc/sh_intc: Avoid using continue in loops hw/intc/sh_intc: Simplify allocating sources array hw/intc/sh_intc: Remove unneeded local variable initialisers hw/timer/sh_timer: Rename sh_timer_state to SHTimerState hw/timer/sh_timer: Do not wrap lines that are not too long hw/timer/sh_timer: Fix timer memory region size hw/timer/sh_timer: Remove use of hw_error hw/char/sh_serial.c | 161 ++++++++++-------- hw/char/trace-events | 4 + hw/intc/sh_intc.c | 371 +++++++++++++++++------------------------- hw/intc/trace-events | 8 + hw/sh4/r2d.c | 5 +- hw/sh4/sh7750.c | 68 +++++--- hw/sh4/trace-events | 3 + hw/sh4/trace.h | 1 + hw/timer/sh_timer.c | 94 +++++------ hw/timer/trace-events | 5 + include/hw/sh4/sh.h | 9 +- meson.build | 1 + 12 files changed, 351 insertions(+), 379 deletions(-) create mode 100644 hw/sh4/trace-events create mode 100644 hw/sh4/trace.h -- 2.21.4
