On 10/29/21 18:35, Richard Henderson wrote: > On 10/28/21 2:08 PM, Philippe Mathieu-Daudé wrote: >> +@3r ...... ... df:2 wt:5ws:5 wd:5 ...... &msa_r > > Nit: should this be called @3rf, since it includes df and...
"3R" is how the manual names this instruction class: Figure 3-40 3R Instruction Format 3R has 2-bit DF field, 3RF has 1-bit DF field. The other arguments are the same (for the helpers). >> +TRANS(SLD, trans_msa_3rf, gen_helper_msa_sld_df); > > ... you use trans_msa_3rf as the implementation? Maybe I should name it trans_msa_3r_or_3rf()? Hmm @3r is actually @3r_df_b (DF=0, DF_BYTE). So trans_msa_3rf() is a good name for it. I could rename @3r -> @3r_df_b but then it doesn't match the manual '3R'. All @3r* use &msa_r structure.
