On 11/1/21 16:31, Richard Henderson wrote: > On 11/1/21 4:27 AM, Laurent Vivier wrote: >> From: Philippe Mathieu-Daudé <f4...@amsat.org> >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> Reviewed-by: Damien Hedde <damien.he...@greensocs.com> >> Message-Id: <20210920064048.2729397-4-f4...@amsat.org> >> Signed-off-by: Laurent Vivier <laur...@vivier.eu> >> --- >> hw/hppa/lasi.c | 10 +++++++++- >> hw/input/lasips2.c | 38 ++++++++++++++++++++++++++++---------- >> include/hw/input/lasips2.h | 17 +++++++++++++---- >> 3 files changed, 50 insertions(+), 15 deletions(-) > > This has broken the qtest-hppa device-introspection test: > > ERROR:../src/qom/object.c:2011:object_get_canonical_path_component: code > should not be reached > Broken pipe > Aborted (core dumped) > > Also, the previous patch 5 does not compile on its own: > > In file included from ../src/hw/input/lasips2.c:28:0: > /home/richard.henderson/qemu/src/include/hw/input/lasips2.h:17:18: > error: field ‘reg’ has incomplete type > MemoryRegion reg; > ^~~ > ninja: build stopped: subcommand failed. > > Reverting to patch 4 builds, and passes the introspection test.
Thank you for the update, I'll have a look.
