On 11/18/21 21:46, John Snow wrote: > If you create two instances of QEMUMachine(), they'll both create the > same nickname by default -- which is not that helpful. > > Luckily, they'll both create unique temporary directories ... but due to > user configuration, they may share logging and sockfile directories, > meaning two instances can collide. The Python logging will also be quite > confusing, with no differentiation between the two instances. > > Add an instance disambiguator (The memory address of the instance) to > the default nickname to foolproof this in all cases. > > Signed-off-by: John Snow <js...@redhat.com> > --- > python/qemu/machine/machine.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
