Hello Markus, On Fri, Nov 12, 2021 at 9:01 AM Markus Armbruster <arm...@redhat.com> wrote: > > Juan Quintela <quint...@redhat.com> writes: > > > Leonardo Bras <leob...@redhat.com> wrote: > >> Add property that allows zerocopy migration of memory pages, > >> and also includes a helper function migrate_use_zerocopy() to check > >> if it's enabled. > >> > >> No code is introduced to actually do the migration, but it allow > >> future implementations to enable/disable this feature. > >> > >> On non-Linux builds this parameter is compiled-out. > >> > >> Signed-off-by: Leonardo Bras <leob...@redhat.com> > > > > Hi > > > >> +# @zerocopy: Controls behavior on sending memory pages on migration. > >> +# When true, enables a zerocopy mechanism for sending memory > >> +# pages, if host supports it. > >> +# Defaults to false. (Since 6.2) > >> +# > > > > This needs to be changed to next release, but not big deal. > > Rename to zero-copy while there. QAPI/QMP strongly prefer separating > words with dashes. "zerocopy" is not a word, "zero" and "copy" are. > > [...] >
Fine then. To make sure it does not look strange, I will change the naming for all the code (zerocopy becomes zero-copy or zero_copy according to the context). Thanks for reviewing! Best regards, Leo
