> On Nov 19, 2021, at 2:42 PM, Alex Williamson <alex.william...@redhat.com>
> wrote:
>
> On Mon, 8 Nov 2021 16:46:35 -0800
> John Johnson <john.g.john...@oracle.com> wrote:
>
>>
>>
>> static void vfio_user_instance_finalize(Object *obj)
>> {
>> + VFIOPCIDevice *vdev = VFIO_PCI_BASE(obj);
>> + VFIODevice *vbasedev = &vdev->vbasedev;
>> +
>> + vfio_put_device(vdev);
>
> This looks suspiciously like the initial function in the previous patch
> should not have been empty. Thanks,
>
It can go in the other patch
JJ
