> -----Original Message----- > From: Richard Henderson [mailto:richard.hender...@linaro.org] > Sent: Sunday, November 21, 2021 6:19 AM > To: Jiangyifei <jiangyi...@huawei.com>; qemu-devel@nongnu.org; > qemu-ri...@nongnu.org > Cc: bin.m...@windriver.com; limingwang (A) <limingw...@huawei.com>; > k...@vger.kernel.org; libvir-l...@redhat.com; anup.pa...@wdc.com; wanbo (G) > <wanb...@huawei.com>; Alistair Francis <alistair.fran...@wdc.com>; > kvm-ri...@lists.infradead.org; Wanghaibin (D) > <wanghaibin.w...@huawei.com>; pal...@dabbelt.com; Fanliang (EulerOS) > <fanli...@huawei.com>; Wubin (H) <wu.wu...@huawei.com> > Subject: Re: [PATCH v1 03/12] target/riscv: Implement function > kvm_arch_init_vcpu > > On 11/20/21 8:46 AM, Yifei Jiang wrote: > > + id = kvm_riscv_reg_id(env, KVM_REG_RISCV_CONFIG, > KVM_REG_RISCV_CONFIG_REG(isa)); > > + ret = kvm_get_one_reg(cs, id, &isa); > > + if (ret) { > > + return ret; > > + } > > + env->misa_mxl |= isa; > > This doesn't look right. > I'm sure you meant > > env->misa_ext = isa; > > > r~
Thanks, it will be modified in the next series. Yifei