On Wed, Dec 15, 2021 at 12:27:43PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing Stefan & Stefano. > > On 11/24/21 14:01, Daniel P. Berrangé wrote: > > openSUSE Leap 15.2 ships with liburing == 0.2 against which QEMU fails > > to build. > > > > ../util/fdmon-io_uring.c: In function ‘fdmon_io_uring_need_wait’: > > ../util/fdmon-io_uring.c:305:9: error: implicit declaration of function > > ‘io_uring_sq_ready’; did you mean ‘io_uring_cq_ready’? > > [-Werror=implicit-function-declaration] > > if (io_uring_sq_ready(&ctx->fdmon_io_uring)) { > > ^~~~~~~~~~~~~~~~~ > > io_uring_cq_ready > > > > This method was introduced in liburing 0.3, so set that as a minimum > > requirement. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > meson.build | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/meson.build b/meson.build > > index e2d38a43e6..04d36bf47e 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -427,7 +427,8 @@ if not get_option('linux_aio').auto() or have_block > > endif > > linux_io_uring = not_found > > if not get_option('linux_io_uring').auto() or have_block > > - linux_io_uring = dependency('liburing', required: > > get_option('linux_io_uring'), > > + linux_io_uring = dependency('liburing', version: '>=0.3', > > + required: get_option('linux_io_uring'), > > method: 'pkg-config', kwargs: static_kwargs) > > endif > > libxml2 = not_found > > >
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature