Am Thu, 6 Jan 2022 10:23:18 +0100 schrieb Volker Rümelin <volker.rueme...@t-online.de>:
> From: Volker Rümelin <vr_q...@t-online.de> > > Replace open-coded buffer arithmetic with the available function > audio_ring_dist(). Because the name audio_ring_dist implies it > calculates the distance between two points, define the alias > function name audio_ring_posb. That's the position in backward > direction of a given point at a given distance. > > Signed-off-by: Volker Rümelin <vr_q...@t-online.de> > --- > audio/audio.c | 25 +++++++------------------ > audio/audio_int.h | 2 ++ > audio/coreaudio.c | 10 ++++------ > audio/sdlaudio.c | 11 +++++------ > 4 files changed, 18 insertions(+), 30 deletions(-) [...] > diff --git a/audio/audio_int.h b/audio/audio_int.h > index 428a091d05..928d8e107e 100644 > --- a/audio/audio_int.h > +++ b/audio/audio_int.h > @@ -266,6 +266,8 @@ static inline size_t audio_ring_dist(size_t dst, > size_t src, size_t len) return (dst >= src) ? (dst - src) : (len - > src + dst); } > > +#define audio_ring_posb(pos, dist, len) audio_ring_dist(pos, dist, > len) I think this will be quite incomprehensible for people reading the source code later (without seeing your commit message above). Thus I'd prefer to directly use audio_ring_dist() everywhere instead. But in case you insist on this macro, please add at least a comment in front of it for explanation. Thomas
