On 1/9/22 1:25 AM, WANG Xuerui wrote:
Although "<< 2" has the same effect as "* 4" here, isn't "<< 2" better in matching the function name?+static inline int shl_2(DisasContext *ctx, int x) +{ + return x * 4;
Yes, good point. r~
- [PATCH v14 22/26] linux-user: Add LoongArch cpu_loop sup... Song Gao
- [PATCH v14 15/26] target/loongarch: Add branch instructi... Song Gao
- [PATCH v14 05/26] target/loongarch: Add fixed point shif... Song Gao
- [PATCH v14 01/26] target/loongarch: Add README Song Gao
- [PATCH v14 23/26] default-configs: Add loongarch linux-u... Song Gao
- [PATCH v14 16/26] target/loongarch: Add disassembler Song Gao
- Re: [PATCH v14 16/26] target/loongarch: Add disasse... WANG Xuerui
- Re: [PATCH v14 16/26] target/loongarch: Add dis... Richard Henderson
- [PATCH v14 06/26] target/loongarch: Add fixed point bit ... Song Gao
- [PATCH v14 20/26] linux-user: Add LoongArch elf support Song Gao
- [PATCH v14 07/26] target/loongarch: Add fixed point load... Song Gao
- [PATCH v14 02/26] target/loongarch: Add core definition Song Gao
- Re: [PATCH v14 02/26] target/loongarch: Add core de... WANG Xuerui
- Re: [PATCH v14 02/26] target/loongarch: Add cor... Richard Henderson
- Re: [PATCH v14 02/26] target/loongarch: Add cor... gaosong
