On 1/7/22 01:17, Richard Henderson wrote: > On 1/4/22 12:54 AM, Philippe Mathieu-Daudé wrote: >> +if have_system or have_tools > ... >> if have_system >> + stub_ss.add(files('fw_cfg.c')) > > Disconnect in tests?
(I assume s/tests/stubs/). fw_cfg-interface.c exposes the fw_cfg QOM interface, which is not used by tools, but since interfaces are checked when QOM object is created, we must include it to be able to use qemu-storage-daemon. fw_cfg.c add a fw_cfg_arch_key_name() stub which is only required for sysemu. So no, there is no disconnect. I will however split this patch in 2 and better describe each change. Thanks, Phil.