Hi, This version implements Cedric's review suggestions from v4. No drastic design changes were made.
Changes from v4: - patches 1,3,5: unchanged - patch 2: * renamed function to pnv_phb4_xscom_realize() * pnv4_phb4_xscom_realize() is now called at the end of phb4_realize() - patch 4: * changed pnv_phb4_get_stack signature to use chip and phb * added a new helper called pnv_pec_stk_default_phb_realize() to realize the default phb when running with defaults - v4 link: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg02148.html Daniel Henrique Barboza (5): ppc/pnv: set phb4 properties in stk_realize() ppc/pnv: move PHB4 XSCOM init to phb4_realize() ppc/pnv: turn 'phb' into a pointer in struct PnvPhb4PecStack ppc/pnv: Introduce user creatable pnv-phb4 devices ppc/pnv: turn pnv_phb4_update_regions() into static hw/pci-host/pnv_phb4.c | 430 ++++++++++++++++++++++++++++++--- hw/pci-host/pnv_phb4_pec.c | 329 ++----------------------- hw/ppc/pnv.c | 2 + include/hw/pci-host/pnv_phb4.h | 8 +- 4 files changed, 431 insertions(+), 338 deletions(-) -- 2.33.1