Re: [Qemu-devel] [PATCH v2] gdbstub: Fix memory leak

[Stefan Weil]

Am 18.10.2011 22:25, schrieb Stefan Weil:

cppcheck report:
   gdbstub.c:1781: error: Memory leak: s

Rearranging of the code avoids the leak.

v2:
Replace the g_malloc0() by g_new0() (suggested by Stuart Brady).

Signed-off-by: Stefan Weil<s...@weilnetz.de>
---
  gdbstub.c |   14 ++++++++------
  1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index 4009058..8bf7167 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1768,12 +1768,6 @@ void gdb_register_coprocessor(CPUState * env,
      GDBRegisterState **p;
      static int last_reg = NUM_CORE_REGS;

-    s = (GDBRegisterState *)g_malloc0(sizeof(GDBRegisterState));
-    s->base_reg = last_reg;
-    s->num_regs = num_regs;
-    s->get_reg = get_reg;
-    s->set_reg = set_reg;
-    s->xml = xml;
      p =&env->gdb_regs;
      while (*p) {
          /* Check for duplicates.  */
@@ -1781,6 +1775,14 @@ void gdb_register_coprocessor(CPUState * env,
              return;
          p =&(*p)->next;
      }
+
+    s = g_new0(GDBRegisterState, 1);
+    s->base_reg = last_reg;
+    s->num_regs = num_regs;
+    s->get_reg = get_reg;
+    s->set_reg = set_reg;
+    s->xml = xml;
+
      /* Add to end of list.  */
      last_reg += num_regs;
      *p = s;

Ping? This patch is still missing for QEMU 1.0.

Kind regards,

Stefan Weil