* Zhang Chen (chen.zh...@intel.com) wrote:
> In the migration_completion() no other status is expected, for
> example MIGRATION_STATUS_CANCELLING, MIGRATION_STATUS_CANCELLED, etc.
>
> Signed-off-by: Zhang Chen <chen.zh...@intel.com>
I think you're right;
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
however, did you actually see this trigger in a different state?
Dave
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 0652165610..2afa77da03 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3205,7 +3205,7 @@ static void migration_completion(MigrationState *s)
> qemu_mutex_unlock_iothread();
>
> trace_migration_completion_postcopy_end_after_complete();
> - } else if (s->state == MIGRATION_STATUS_CANCELLING) {
> + } else {
> goto fail;
> }
>
> --
> 2.25.1
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
