On Fri, Jan 21, 2022 at 2:15 PM Cleber Rosa <cr...@redhat.com> wrote: > > > John Snow <js...@redhat.com> writes: > > > setuptools is a package that replaces the python stdlib 'distutils'. It > > is generally installed by all venv-creating tools "by default". It isn't > > actually needed at runtime for the qemu package, so our own setup.cfg > > does not mention it as a dependency. > > > > However, tox will create virtual environments that include it, and will > > upgrade it to the very latest version. the 'venv' tool will also include > > whichever version your host system happens to have. > > > > Unfortunately, setuptools version 60.0.0 and above include a hack to > > forcibly overwrite python's built-in distutils. The pylint tool that we > > use to run code analysis checks on this package relies on distutils and > > suffers regressions when setuptools >= 60.0.0 is present at all, see > > https://github.com/PyCQA/pylint/issues/5704 > > > > Instruct tox and the 'check-dev' targets to avoid setuptools packages > > that are too new, for now. Pipenv is unaffected, because setuptools 60 > > does not offer Python 3.6 support, and our pipenv config is pinned > > against Python 3.6. > > > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > python/Makefile | 2 ++ > > python/setup.cfg | 1 + > > 2 files changed, 3 insertions(+) > > > > Reviewed-by: Cleber Rosa <cr...@redhat.com> > Tested-by: Cleber Rosa <cr...@redhat.com> >
Infinite gratitude. I've staged this patch and will send a PR shortly (Assuming I can determine that the failures I'm seeing on GitLab right now are not my fault.) Thanks, --js
