Re: [PATCH] meson: Use find_program() to resolve the entitlement.sh script

[Paolo Bonzini]

On 1/24/22 10:04, Akihiko Odaki wrote:

On Mon, Jan 24, 2022 at 5:16 PM Richard Henderson
<richard.hender...@linaro.org> wrote:

On 1/22/22 11:20 AM, Philippe Mathieu-Daudé via wrote:

Using ../configure without any particular option generates 31 targets
on Darwin, and meson search for the entitlement.sh script 31 times:

    Program nm found: YES
    Program scripts/undefsym.py found: YES 
(/opt/homebrew/opt/python@3.9/bin/python3.9 /Code/qemu/scripts/undefsym.py)
    Program scripts/feature_to_c.sh found: YES (/bin/sh 
/Code/qemu/scripts/feature_to_c.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Program scripts/entitlement.sh found: YES 
(/Code/qemu/scripts/entitlement.sh)
    Configuring 50-edk2-i386-secure.json using configuration
    Configuring 50-edk2-x86_64-secure.json using configuration

Use find_program() which seems to cache the script path once found.

Signed-off-by: Philippe Mathieu-Daudé<f4...@amsat.org>
---
   meson.build | 9 +++------
   1 file changed, 3 insertions(+), 6 deletions(-)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~

Reviewed-by: Akihiko Odaki <akihiko.od...@gmail.com>

Queued, thanks.