On Tue, 25 Jan 2022 18:51:54 +0100 Christian Schoenebeck <qemu_...@crudebyte.com> wrote:
> On Dienstag, 25. Januar 2022 16:33:46 CET Greg Kurz wrote: > > On Sat, 22 Jan 2022 20:12:16 +0100 > > > > Christian Schoenebeck <qemu_...@crudebyte.com> wrote: > > > The 9p test cases use mkdtemp() to create a temporary directory for > > > running the 'local' 9p tests with real files/dirs. Unlike mktemp() > > > which only generates a unique file name, mkdtemp() also creates the > > > directory, therefore the subsequent mkdir() was wrong and caused > > > errors on some systems. > > > > > > Signed-off-by: Christian Schoenebeck <qemu_...@crudebyte.com> > > > Fixes: 136b7af2 (tests/9pfs: fix test dir for parallel tests) > > > Reported-by: Daniel P. Berrangé <berra...@redhat.com> > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/832 > > > --- > > > > Reviewed-by: Greg Kurz <Greg Kurz <gr...@kaod.org> > > Hey, a live sign. :) > Yeah... My current engagement with kata containers doesn't leave me much time to do anything else and I just had covid ;-) > > Unrelated, the template pointer is leaked. It looks like g_autofree would > > help here. I'll post a follow-up to fix that. > > This man knows what I like to read! > Heh :-) > Best regards, > Christian Schoenebeck > >