On 2/8/22 16:10, Thomas Huth wrote:
Before we go down that road, I think it would be better to get rid of
the "auto" group and add the list of the iotests that should get run
during "make check" to the meson.build file directly. That's easier to
understand and less confusing.

There are other groups than "auto", though. It's a bit contrarian to the aim that changing one aspect of the build should only touch a single place (see commit 32fcc6244c, "contrib/vhost-user-input: convert to meson", for a reminder of what it was like to add an executable with Makefiles!).

diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
index 0eace147b8..d45a2688a0 100644
--- a/tests/qemu-iotests/testrunner.py
+++ b/tests/qemu-iotests/testrunner.py
@@ -404,7 +404,7 @@ def run_tests(self, tests: List[str], jobs: int = 1) -> bool:
              if res.status == 'fail':
                  failed.append(name)
                  if res.diff:
-                    print('\n'.join(res.diff))
+                    print('\n'.join(res.diff), file=sys.stderr)
              elif res.status == 'not run':
                  notrun.append(name)
              elif res.status == 'pass':

Interesting.  But it should be done only if self.tap is true.

Paolo


Reply via email to