On Tue, 21 Dec 2021 at 06:35, Alistair Francis <alistai...@gmail.com> wrote: > > On Mon, Dec 20, 2021 at 5:52 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > On Thu, Dec 16, 2021 at 12:55 PM Alistair Francis > > <alistair.fran...@opensource.wdc.com> wrote: > > > > > > From: Alistair Francis <alistair.fran...@wdc.com> > > > > > > As per the device tree specification let's set the clock-frequency for > > > the virt CPUs. > > > > > > QEMU doesn't really have an exact clock, so let's just 1000000 as it's a > > > nice round number and matches the sifive_u CLINT_TIMEBASE_FREQ. > > > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/472 (RISC-V virt) > > > > I tend to think this issue is not valid, as the comment in the issue > > says the value should reflect the running frequency. > > > > Note the "clock-frequency" was once in the codes but was intentionally > > removed before because it is not needed: > > > > See commit 7ae05377b85f (" riscv: hw: Drop "clock-frequency" property > > of cpu nodes") > > Hmmm... Good point. > > But if the device tree spec says it's required then I think we should > include it. Even if it isn't super relevant for us
I talked with one of the device tree spec maintainers, and he said that the "required" note on this property in the spec is a leftover from the spec text for PPC ePAPR, and it isn't actually required these days. Many DTs for real-hardware Arm boards don't set the property, and it's not marked as required in the devicetree yaml schema for the cpu node: https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/cpus.yaml#L63 thanks -- PMM
