On Mon, Feb 28, 2022 at 1:07 PM Markus Armbruster <arm...@redhat.com> wrote:
> Vladislav Yaroshchuk <vladislav.yaroshc...@jetbrains.com> writes: > > > Create separate netdevs for each vmnet operating mode: > > - vmnet-host > > - vmnet-shared > > - vmnet-bridged > > > > Signed-off-by: Vladislav Yaroshchuk <vladislav.yaroshc...@jetbrains.com> > > I acked v8 and v13 of the QAPI schema part. You should add Acked-by and > Reviewed-by you receive in later revisions, unless you make changes that > invalidate them. When in doubt, drop them. However, this patch is > identical to v13. You dropping my Acked-by made me look at it again, > wasting my time. Please don't. > > I missed the qapi discussion thread while working on other parts, sincerely apologize. Don't want to waste your time, sorry. > > diff --git a/qapi/net.json b/qapi/net.json > > index 7fab2e7cd8..b922e2e34f 100644 > > --- a/qapi/net.json > > +++ b/qapi/net.json > > @@ -452,6 +452,120 @@ > > '*vhostdev': 'str', > > '*queues': 'int' } } > > > > +## > > +# @NetdevVmnetHostOptions: > > +# > > +# vmnet (host mode) network backend. > > +# > > +# Allows the vmnet interface to communicate with other vmnet > > +# interfaces that are in host mode and also with the host. > > +# > > +# @start-address: The starting IPv4 address to use for the interface. > > +# Must be in the private IP range (RFC 1918). Must be > > +# specified along with @end-address and @subnet-mask. > > +# This address is used as the gateway address. The > > +# subsequent address up to and including end-address are > > +# placed in the DHCP pool. > > +# > > +# @end-address: The DHCP IPv4 range end address to use for the > > +# interface. Must be in the private IP range (RFC 1918). > > +# Must be specified along with @start-address and > > +# @subnet-mask. > > +# > > +# @subnet-mask: The IPv4 subnet mask to use on the interface. Must > > +# be specified along with @start-address and @subnet-mask. > > +# > > +# @isolated: Enable isolation for this interface. Interface isolation > > +# ensures that vmnet interface is not able to communicate > > +# with any other vmnet interfaces. Only communication with > > +# host is allowed. Available since macOS Big Sur 11.0. > > In review of v13, I suggested to replace "Available since macOS Big Sur > 11.0" by "Requires at least macOS Big Sur 11.0" here and below, and you > agreed. Looks like you forgot to actually change them. > > With these changes, QAPI schema > Acked-by: Markus Armbruster <arm...@redhat.com> > > Fixed locally, will submit within the next version. Thank you! [...] > > Best Regards, Vladislav Yaroshchuk
