The dump/dump.c file has lots of duplicated code for handling 64 and 32 bit elf files. Additionally there are many instances where code can be improved by adding a variable to avoid having to specify the same calculation or check over and over.
This series is the cleanup step onto which my series that adds custom section support and finally the series that introduces PV dump support are based on. Personal comments: I'd be happy if someone looks at the error handling. It's taken me quite a while to understand how the code works and I expect that this patch might improve that but it won't fix every issue. Going forward it might make sense to split kdump and elf dump code into separate files and also cleanup the kdump code. Janosch Frank (7): dump: Introduce shdr_num to decrease complexity dump: Remove the sh_info variable dump: Add more offset variables dump: Introduce dump_is_64bit() helper function dump: Consolidate phdr note writes dump: Cleanup dump_begin write functions dump: Consolidate elf note function dump/dump.c | 256 +++++++++++++++++++----------------------- include/sysemu/dump.h | 15 ++- 2 files changed, 125 insertions(+), 146 deletions(-) -- 2.32.0
