On 03/03/2022 15:26, Peter Maydell wrote:
On Wed, 2 Mar 2022 at 21:31, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote:These fields are required in the migration stream to restore macfb state correctly. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/display/macfb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/macfb.c b/hw/display/macfb.c index dfdae90144..7371986480 100644 --- a/hw/display/macfb.c +++ b/hw/display/macfb.c @@ -625,9 +625,11 @@ static const VMStateDescription vmstate_macfb = { .minimum_version_id = 1, .post_load = macfb_post_load, .fields = (VMStateField[]) { + VMSTATE_UINT8(type, MacfbState), VMSTATE_UINT8_ARRAY(color_palette, MacfbState, 256 * 3), VMSTATE_UINT32(palette_current, MacfbState), VMSTATE_UINT32_ARRAY(regs, MacfbState, MACFB_NUM_REGS), + VMSTATE_TIMER_PTR(vbl_timer, MacfbState), VMSTATE_END_OF_LIST() } };Same bump-versions-or-explain-why-not as previous patch, otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
... and the same explanation applies here too. Should I still mention this in the commit messages for both this and the previous patch?
ATB, Mark.
