On Fri, Mar 4, 2022 at 6:49 PM Michael S. Tsirkin <m...@redhat.com> wrote: > > On Fri, Mar 04, 2022 at 05:22:57PM +0530, Ani Sinha wrote: > > From: Liav Albani <liav...@gmail.com> > > > > After changing the IAPC boot flags register to indicate support of i8042 > > in the machine chipset to help the guest OS to determine its existence > > "faster", we need to have the updated FACP ACPI binary images in tree. > > > > The ASL changes introduced are shown by the following diff: > > > > @@ -42,35 +42,35 @@ > > [059h 0089 1] PM1 Control Block Length : 02 > > [05Ah 0090 1] PM2 Control Block Length : 00 > > [05Bh 0091 1] PM Timer Block Length : 04 > > [05Ch 0092 1] GPE0 Block Length : 10 > > [05Dh 0093 1] GPE1 Block Length : 00 > > [05Eh 0094 1] GPE1 Base Offset : 00 > > [05Fh 0095 1] _CST Support : 00 > > [060h 0096 2] C2 Latency : 0FFF > > [062h 0098 2] C3 Latency : 0FFF > > [064h 0100 2] CPU Cache Size : 0000 > > [066h 0102 2] Cache Flush Stride : 0000 > > [068h 0104 1] Duty Cycle Offset : 00 > > [069h 0105 1] Duty Cycle Width : 00 > > [06Ah 0106 1] RTC Day Alarm Index : 00 > > [06Bh 0107 1] RTC Month Alarm Index : 00 > > [06Ch 0108 1] RTC Century Index : 32 > > -[06Dh 0109 2] Boot Flags (decoded below) : 0000 > > +[06Dh 0109 2] Boot Flags (decoded below) : 0002 > > Legacy Devices Supported (V2) : 0 > > - 8042 Present on ports 60/64 (V2) : 0 > > + 8042 Present on ports 60/64 (V2) : 1 > > VGA Not Present (V4) : 0 > > MSI Not Supported (V4) : 0 > > PCIe ASPM Not Supported (V4) : 0 > > CMOS RTC Not Present (V5) : 0 > > [06Fh 0111 1] Reserved : 00 > > [070h 0112 4] Flags (decoded below) : 000084A5 > > WBINVD instruction is operational (V1) : 1 > > WBINVD flushes all caches (V1) : 0 > > All CPUs support C1 (V1) : 1 > > C2 works on MP system (V1) : 0 > > Control Method Power Button (V1) : 0 > > Control Method Sleep Button (V1) : 1 > > RTC wake not in fixed reg space (V1) : 0 > > RTC can wake system from S4 (V1) : 1 > > 32-bit PM Timer (V1) : 0 > > Docking Supported (V1) : 0 > > > > Signed-off-by: Liav Albani <liav...@gmail.com> > > Acked-by: Ani Sinha <a...@anisinha.ca> > > Fails make check: > ▶ 3/60 ERROR:../tests/qtest/bios-tables-test.c:532:test_acpi_asl: assertion > failed: (all_tables_match) ERROR
Unable to repro this even after rebasing to latest master.
