On 11.03.22 19:49, Ilya Leoshkevich wrote:
> When RI2 is 0x80000000, qemu enters an infinite loop instead of jumping
> backwards. Fix by adding a missing cast, like in in2_ri2().
>
> Fixes: 7233f2ed1717 ("target-s390: Convert BRANCH ON CONDITION")
> Signed-off-by: Ilya Leoshkevich <i...@linux.ibm.com>
> ---
> target/s390x/tcg/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
> index 41c8696185..5acfc0ff9b 100644
> --- a/target/s390x/tcg/translate.c
> +++ b/target/s390x/tcg/translate.c
> @@ -1201,7 +1201,7 @@ static DisasJumpType help_branch(DisasContext *s,
> DisasCompare *c,
> bool is_imm, int imm, TCGv_i64 cdest)
> {
> DisasJumpType ret;
> - uint64_t dest = s->base.pc_next + 2 * imm;
> + uint64_t dest = s->base.pc_next + (int64_t)imm * 2;
> TCGLabel *lab;
>
> /* Take care of the special cases first. */
Reviewed-by: David Hildenbrand <da...@redhat.com>
--
Thanks,
David / dhildenb
