On Fri, Nov 25, 2011 at 12:49 PM, Benjamin <mlspira...@gmail.com> wrote:
> + fd = qemu_socket(PF_INET, SOCK_DGRAM, 0);
> + if (fd < 0) {
> + perror("socket(PF_INET, SOCK_DGRAM)");
> + return -1;
> + }
> + val = 1;
> + ret = setsockopt(fd, SOL_SOCKET, SO_REUSEADDR,
> + (const char *)&val, sizeof(val));
> + if (ret < 0) {
> + perror("setsockopt(SOL_SOCKET, SO_REUSEADDR)");
Please avoid leaking the file descriptor on error:
closesocket(fd);
Since existing code also does this it may be more appropriate to send
a follow-up patch that cleans up all of net/socket.c.
Reviewed-by: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com>
Stefan
