I've being using the examples as unit tests and found a few that
doesn't work out-of-the-box, might be inteded in order to be less
verbose in the qapi documentation but nevertheless I'm sending this
out in case you want to cherry-pick them.
* Changes in v2:
02/14: qapi: fix example of BLOCK_IMAGE_CORRUPTED event
- changed the example to an actual error picked from
qemu-iotests/60.out
- added recent timestamp :)
03/14: qapi: fix example of BLOCK_IO_ERROR event
- use real error message, in this case "No space left on device"
04/14: qapi: fix example of BLOCK_JOB_PENDING event
- added an extra space
- added recent timestamp
07/14: qapi: fix example of UNPLUG_PRIMARY event
- amended commit message
08/14: qapi: fix example of FAILOVER_NEGOTIATED event
- fixed syntax for proper document parameter
09/14: qapi: run-state examples: add missing member
- fixed commit message
10/14: qapi: run-state examples: add missing timestamp
- added chronological timestamps ;)
Cheers,
Victor Toso (14):
qapi: BlockExportRemoveMode: move comments to TODO
qapi: fix example of BLOCK_IMAGE_CORRUPTED event
qapi: fix example of BLOCK_IO_ERROR event
qapi: fix example of BLOCK_JOB_PENDING event
qapi: fix example of DUMP_COMPLETED event
qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event
qapi: fix example of UNPLUG_PRIMARY event
qapi: fix example of FAILOVER_NEGOTIATED event
qapi: fix examples: SHUTDOWN and RESET events
qapi: run-state examples: add missing timestamp
qapi: fix example of MEMORY_FAILURE
qapi: ui examples: add missing websocket member
qapi: fix example of ACPI_DEVICE_OST event
qapi: fix example of dump-guest-memory
qapi/acpi.json | 5 +++--
qapi/block-core.json | 14 +++++++-------
qapi/block-export.json | 10 +++++-----
qapi/dump.json | 9 +++++----
qapi/machine.json | 3 ++-
qapi/migration.json | 4 +++-
qapi/net.json | 6 ++++--
qapi/run-state.json | 16 +++++++++++-----
qapi/ui.json | 12 ++++++------
9 files changed, 46 insertions(+), 33 deletions(-)
--
2.35.1
