Daniel P. Berrangé <berra...@redhat.com> wrote: > Juan, > > would you be able to include at least patch 6 in a migration > pull before release ?
Yeap, will do tomorrow. Later, Juan. > On Fri, Mar 11, 2022 at 09:58:24AM +0800, Peter Xu wrote: >> On Thu, Mar 10, 2022 at 05:18:03PM +0000, Daniel P. Berrangé wrote: >> > This significantly expands the migration test suite to cover testing >> > with TLS over TCP and UNIX sockets, with both PSK (pre shared keys) >> > and x509 credentials, and for both single and multifd scenarios. >> > >> > It identified one bug in handling PSK credentials with UNIX sockets, >> > but other than that everything was operating as expected. >> > >> > To minimize the impact on code duplication alopt of refactoring is >> > done of the migration tests to introduce a common helper for running >> > the migration process. The various tests mostly just have to provide >> > a callback to set a few parameters/capabilities before migration >> > starts, and sometimes a callback to cleanup or validate after >> > completion/failure. >> > >> > There is one functional bugfix in patch 6, I would like to see >> > in 7.0. The rest is all test suite additions, and I don't mind >> > if they are in 7.0 or 7.1 >> >> At least patch 1-4, 6-10 look already good candidates for 7.0, imho, if not >> all.. >> >> Thanks for doing this, Daniel. >> >> -- >> Peter Xu >> > > With regards, > Daniel