On Thu, Mar 24, 2022 at 9:33 PM Eric Blake <ebl...@redhat.com> wrote: > > On Thu, Mar 24, 2022 at 02:30:06PM -0400, John Snow wrote: > > Without this change, asserting that qemu_io always returns 0 causes this > > test to fail in a way we happened not to be catching previously: > > > > qemu.utils.VerboseProcessError: Command > > '('/home/jsnow/src/qemu/bin/git/tests/qemu-iotests/../../qemu-io', > > '--cache', 'writeback', '--aio', 'threads', '-f', 'qcow2', '-c', > > 'read -P 4 3M 1M', > > '/home/jsnow/src/qemu/bin/git/tests/qemu-iotests/scratch/3.img')' > > returned non-zero exit status 1. > > ┏━ output ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ > > ┃ qemu-io: can't open device > > ┃ /home/jsnow/src/qemu/bin/git/tests/qemu-iotests/scratch/3.img: > > ┃ Could not open backing file: Could not open backing file: Throttle > > ┃ group 'tg' does not exist > > ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ > > > > Explicitly provide the backing file so that opening the file outside of > > QEMU (Where we will not have throttle groups) will succeed. > > > > [Patch entirely written by Hanna but I don't have her S-o-B] > > Yeah, you'll want that. > > > [My commit message is probably also garbage, sorry] > > No, it was actually decent. > > > [Feel free to suggest a better one] > > [I hope your day is going well] > > Signed-off-by: John Snow <js...@redhat.com> > > > > Signed-off-by: John Snow <js...@redhat.com> > > So giving your S-o-b twice makes up for it, right ;)
This happens when I add a '---' myself into the commit message, and git-publish sees that the end of the commit message doesn't have a S-o-B and adds one into the ignored region. Haven't bothered to fix it yet. > > Well, you did say v3 would fix this. But while you're having fun > fixing it, you can add: > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org >