On 4/1/2022 1:08 PM, Gerd Hoffmann wrote:
               if (sev_enabled()) {

                     ^^^

Can we remove the SEV check ...

+    pc_system_parse_ovmf_flash(ptr, size);
+
+    if (sev_enabled()) {

... because we are still checking SEV here.

Well, the two checks have slightly different purposes.  The first check
will probably become "if (sev || tdx)" soon,

Not soon for TDX since the hacky pflash interface to load TDVF is rejected.

whereas the second will
become "if (sev) { ... } if (tdx) { ... }".

We could remove the first.  pc_system_parse_ovmf_flash() would run
unconditionally then.  Not needed, but should not have any bad side
effects.

take care,
   Gerd



Reply via email to