On Mon, Mar 28 2022, Paolo Bonzini <pbonz...@redhat.com> wrote: > Remove unecessary use of #ifdef CONFIG_VHOST_SCSI, instead just use a > separate file and a separate rule in meson.build. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > hw/s390x/meson.build | 1 + > hw/s390x/vhost-scsi-ccw.c | 64 ++++++++++++++++++++++++++++++++++++++ > hw/s390x/virtio-ccw-scsi.c | 47 ---------------------------- > 3 files changed, 65 insertions(+), 47 deletions(-) > create mode 100644 hw/s390x/vhost-scsi-ccw.c >
> diff --git a/hw/s390x/vhost-scsi-ccw.c b/hw/s390x/vhost-scsi-ccw.c As Eric already noted, please add an entry in MAINTAINERS under virtio-ccw for this file. > new file mode 100644 > index 0000000000..b68ddddd1c > --- /dev/null > +++ b/hw/s390x/vhost-scsi-ccw.c > @@ -0,0 +1,64 @@ > +/* > + * vhost ccw scsi implementation > + * > + * Copyright 2012, 2015 IBM Corp. > + * Author(s): Cornelia Huck <cornelia.h...@de.ibm.com> That old copyright notice gets copied around a lot; what I find funny here is that you actually introduced the device in the first place :) (commit ccf6916c843edd30ea4ecfaaac68faa865529c97) (I believe we really can't do any better, and I probably did touch this while still wearing my IBM hat.) > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or (at > + * your option) any later version. See the COPYING file in the top-level > + * directory. > + */
