On 4/8/22 07:15, Peter Maydell wrote:
In process_mapti() we check interrupt IDs to see whether they are in the valid LPI range. Factor this out into its own utility function, as we're going to want it elsewhere too for GICv4.Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> --- hw/intc/arm_gicv3_its.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index f8467b61ec5..400cdf83794 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -79,6 +79,12 @@ typedef enum ItsCmdResult { CMD_CONTINUE = 1, } ItsCmdResult;+static inline bool intid_in_lpi_range(uint32_t id)+{ + return id >= GICV3_LPI_INTID_START && + id < (1ULL << (GICD_TYPER_IDBITS + 1)); +}
Ok, I guess. Though there's no need for ULL, and a 64-bit comparison.
- uint32_t num_intids;
You didn't have one here, and GICD_TYPER_IDBITS is 15. Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
