Hi On Wed, Apr 20, 2022 at 6:53 PM Thomas Huth <th...@redhat.com> wrote: > > On 20/04/2022 16.46, Marc-André Lureau wrote: > > Hi > > > > On Wed, Apr 20, 2022 at 6:37 PM Thomas Huth <th...@redhat.com> wrote: > >> > >> On 20/04/2022 16.10, Daniel P. Berrangé wrote: > >>> On Wed, Apr 20, 2022 at 05:26:00PM +0400, marcandre.lur...@redhat.com > >>> wrote: > >>>> From: Marc-André Lureau <marcandre.lur...@redhat.com> > >>>> > >>>> According to our configure checks, this is the list of supported > >>>> compilers. > >>>> > >>>> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > >>>> Reviewed-by: Damien Hedde <damien.he...@greensocs.com> > >>>> --- > >>>> docs/about/build-platforms.rst | 10 ++++++++++ > >>>> 1 file changed, 10 insertions(+) > >>>> > >>>> diff --git a/docs/about/build-platforms.rst > >>>> b/docs/about/build-platforms.rst > >>>> index c29a4b8fe649..1980c5d2476f 100644 > >>>> --- a/docs/about/build-platforms.rst > >>>> +++ b/docs/about/build-platforms.rst > >>>> @@ -92,6 +92,16 @@ hosted on Linux (Debian/Fedora). > >>>> The version of the Windows API that's currently targeted is Vista / > >>>> Server > >>>> 2008. > >>>> > >>>> +Supported compilers > >>>> +------------------- > >>>> + > >>>> +To compile, QEMU requires either: > >>>> + > >>>> +- GCC >= 7.4.0 > >>>> +- Clang >= 6.0 > >>>> +- XCode Clang >= 10.0 > >>> > >>> Do we need to spell out the versions explicitly ? These versions are > >>> all derived from what's available in the repos of the supported build > >>> platforms, similar to any other build deps we have. I don't think we > >>> want to start a precedent of duplicating versions in this doc for > >>> build deps we have, and there's nothing particularly special about > >>> compilers in this respect. > >> > >> I agree with Daniel - when I saw this patch, the first thought that I had > >> was: "This will be getting out of sync quickly" ... > > > > I don't have the impression we bump our compiler requirement regularly > > or lightly. > > "quickly" in the sense of that it will be out of sync once somebody bumps > the version check in the "configure" script - since I doubt that it will be > remembered to update this document here as well. > > >> so I'd also recommend to rather not add this here. > > > > Outdated documentation is still better than no documentation. YMMV. > > Well, no. In this case, it might rather create wrong expectations for the > users if they read that their compiler is still supported, but the configure > script refuses it. > > Anyway, if you feel like we need more information for the users about > supported systems and compiler versions, feel free to update this page here > instead, it has also fallen behind already quite a bit: > > https://wiki.qemu.org/Supported_Build_Platforms
Unfortunately, that page is not helpful to answer the question which compiler is required. And given it's construction, it is by nature always obsolete :) Furthermore, nowadays, we should have reference documentation in the repo, not on the wiki.
