On Wed, Apr 20, 2022 at 05:26:06PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Do not require the whole option machinery to handle keyval, as it is > used by QAPI alone, without the option API. And match the associated > unit name.
Great, I really dislike it when the .h file name doesn't match the name where I'll find the .c file impl > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > include/qemu/keyval.h | 14 ++++++++++++++ > include/qemu/option.h | 6 ------ > qapi/qobject-input-visitor.c | 2 +- > qom/object_interfaces.c | 1 + > softmmu/vl.c | 1 + > tests/unit/check-qom-proplist.c | 1 + > tests/unit/test-forward-visitor.c | 2 +- > tests/unit/test-keyval.c | 2 +- > util/keyval.c | 2 +- > 9 files changed, 21 insertions(+), 10 deletions(-) > create mode 100644 include/qemu/keyval.h Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
