On Wed, Apr 20, 2022 at 05:10:51PM +0100, Peter Maydell wrote: > On Wed, 20 Apr 2022 at 16:04, Daniel P. Berrangé <berra...@redhat.com> wrote: > > > > On Wed, Apr 20, 2022 at 05:25:49PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Could use a commit message explaining why this is a good > > idea. > > > > I see it contains QEMU_COPYRIGHT macro, but it also then > > contains QEMU_HELP_BOTTOM which is about bug reporting > > not copyright. > > > > IMHO something like 'qemu-cli.h' could be a better match > > "-cli" is both too broad and also inaccurate, because we use > these macros in the GUI UI frontends too. It's "macros defining > strings for use in version/usage/help dialogs and output". > Maybe qemu/help-texts.h ?
I guess I tend to still view qemu-system-XXX as cli, despite the possibility of a GUI, since you're passing 10's/100's of CLI parameters regardless. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
