On Wed, Apr 27, 2022 at 4:30 PM Si-Wei Liu <si-wei....@oracle.com> wrote: > > > > On 4/26/2022 9:28 PM, Jason Wang wrote: > > > > 在 2022/3/30 14:33, Si-Wei Liu 写道: > >> Hi, > >> > >> This patch series attempt to fix a few issues in vhost-vdpa > >> multiqueue functionality. > >> > >> Patch #1 is the formal submission for RFC patch in: > >> https://urldefense.com/v3/__https://lore.kernel.org/qemu-devel/c3e931ee-1a1b-9c2f-2f59-cb4395c23...@oracle.com/__;!!ACWV5N9M2RV99hQ!OoUKcyWauHGQOM4MTAUn88TINQo5ZP4aaYyvyUCK9ggrI_L6diSZo5Nmq55moGH769SD87drxQyqg3ysNsk$ > >> > >> Patch #2 and #3 were taken from a previous patchset posted on > >> qemu-devel: > >> https://urldefense.com/v3/__https://lore.kernel.org/qemu-devel/20211117192851.65529-1-epere...@redhat.com/__;!!ACWV5N9M2RV99hQ!OoUKcyWauHGQOM4MTAUn88TINQo5ZP4aaYyvyUCK9ggrI_L6diSZo5Nmq55moGH769SD87drxQyqc3mXqDs$ > >> > >> albeit abandoned, two patches in that set turn out to be useful for > >> patch #4, which is to fix a QEMU crash due to race condition. > >> > >> Patch #5 through #7 are obviously small bug fixes. Please find the > >> description of each in the commit log. > >> > >> Thanks, > >> -Siwei > > > > > > Hi Si Wei: > > > > I think we need another version of this series? > Hi Jason, > > Apologies for the long delay. I was in the middle of reworking the patch > "virtio: don't read pending event on host notifier if disabled", but > found out that it would need quite some code change for the userspace > fallback handler to work properly (for the queue no. change case > specifically).
We probably need this fix for -stable, so I wonder if we can have a workaround first and do refactoring on top? > I have to drop it from the series and posted it later on > when ready. Will post a v2 with relevant patches removed. Thanks > > Regards, > -Siwei > > > > > Thanks > > > > > >> > >> --- > >> > >> Eugenio Pérez (2): > >> virtio-net: Fix indentation > >> virtio-net: Only enable userland vq if using tap backend > >> > >> Si-Wei Liu (5): > >> virtio-net: align ctrl_vq index for non-mq guest for vhost_vdpa > >> virtio: don't read pending event on host notifier if disabled > >> vhost-vdpa: fix improper cleanup in net_init_vhost_vdpa > >> vhost-net: fix improper cleanup in vhost_net_start > >> vhost-vdpa: backend feature should set only once > >> > >> hw/net/vhost_net.c | 4 +++- > >> hw/net/virtio-net.c | 25 +++++++++++++++++++++---- > >> hw/virtio/vhost-vdpa.c | 2 +- > >> hw/virtio/virtio-bus.c | 3 ++- > >> hw/virtio/virtio.c | 21 +++++++++++++-------- > >> include/hw/virtio/virtio.h | 2 ++ > >> net/vhost-vdpa.c | 4 +++- > >> 7 files changed, 45 insertions(+), 16 deletions(-) > >> > > >
