On Thu, Apr 28, 2022 at 04:13:02PM -0700, Dongwon Kim wrote:
> Introducing a new integer parameter to specify the monitor where the
> Qemu window is placed upon launching.
>
> Monitor can be any number between 0 and (total number of monitors - 1).
>
> It can be used together with full-screen=on, which will make the QEMU
> window full-screened on the targeted monitor.
>
> v2: fixed typos and updated commit subject and msg
> (Philippe Mathieu-Daudé)
>
> changed param name to monitor, removed unnecessary condition check
> on the parameter
> (Paolo Bonzini)
>
> v3: updated Since version to 7.1 for monitor parameter
>
> Cc: Philippe Mathieu-Daudé <phi...@redhat.com>
> Cc: Paolo Bonzini <pbonz...@redhat.com>
> Cc: Gerd Hoffmann <kra...@redhat.com>
> Cc: Vivek Kasireddy <vivek.kasire...@intel.com>
> Signed-off-by: Dongwon Kim <dongwon....@intel.com>
> ---
> qapi/ui.json | 6 +++++-
> qemu-options.hx | 2 +-
> ui/gtk.c | 8 ++++++++
> 3 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 059302a5ef..ddcea7349b 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -1204,13 +1204,17 @@
> # assuming the guest will resize the display to match
> # the window size then. Otherwise it defaults to "off".
> # Since 3.1
> +# @monitor: Indicate monitor where QEMU window is lauched. monitor
> +# could be any number from 0 to (total num of monitors - 1).
> +# since 7.1
> #
> # Since: 2.12
> #
> ##
> { 'struct' : 'DisplayGTK',
> 'data' : { '*grab-on-hover' : 'bool',
> - '*zoom-to-fit' : 'bool' } }
> + '*zoom-to-fit' : 'bool',
> + '*monitor' : 'uint32' } }
I feel like this ought to be an array of monitors, so that we can have
explicit positioning when we have multiple graphical outputs and are
creating a separate window for each.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
