On 05/05/2022 13:26, Helge Deller wrote:

On 5/4/22 17:37, Mark Cave-Ayland wrote:
Patch 1 updates artist.c to fix some style issues and ensure that artist.c 
passes
checkpatch for the remainder of the patchset, whilst patch 2 removes the 
ROP8OFF()
macro which is currently unused.

Finally patch 3 is the main reason for this patchset and improves the 
performance
of the artist framebuffer by only rendering the dirty scanlines to the display
surface, which noticeably improves boot times and makes the GTK UI usable on my
fairly modest laptop.

[Helge/Sven: if you can provide a Tested-by or Reviewed-by tag for this patchset
before the weekend, I can include it in my PR containing all the other HPPA
updates]

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>

I tested it and indeed, the GTK GUI is now really much faster, even with the
GTK window forwarded over X11.

Excellent!

Ideally, can the patch #3 (the GTK speedup) be backported?

I'm not sure that it would really make a difference in this case: if this were queued for 7.0 then that wouldn't be released until a few weeks after 7.1, and even then its likely that the stable distros would be using something older regardless so it wouldn't get picked up anyhow.

I applied, reviewed and tested it. Please add:

Reviewed-by: Helge Deller <del...@gmx.de>

Thanks - I'll add your R-B to the artist series.


ATB,

Mark.

Reply via email to