Re: [PATCH v5 06/10] hmp: add basic "info stats" implementation

[Paolo Bonzini]

On 6/7/22 20:35, Dr. David Alan Gilbert wrote:
+        monitor_printf(mon, "%s", iec_binary_prefix(value->exponent));
OK that's better; but it's a shame the limits don't come from something
shared; iec_binary_prefix goes upto 60 and si_prefix goes way below -9
Reviewed-by: Dr. David Alan Gilbert<dgilb...@redhat.com>


I can remove the limits altogether, and consider it a bug of the 
provider if they're not respected, but it's a bit ugly to have an 
assertion failure in that case.

Paolo