On Tue, Jun 14, 2022 at 5:09 AM Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Mon, Jun 13, 2022 at 09:50:43PM -0400, John Snow wrote: > > The old CentOS image didn't work anymore because it was already EOL at > > the beginning of 2022. > > > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > tests/vm/centos | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/tests/vm/centos b/tests/vm/centos > > index be4f6ff2f14..f5bbdecf62d 100755 > > --- a/tests/vm/centos > > +++ b/tests/vm/centos > > @@ -1,8 +1,8 @@ > > #!/usr/bin/env python3 > > # > > -# CentOS image > > +# CentOS 8 Stream image > > # > > -# Copyright 2018 Red Hat Inc. > > +# Copyright 2018, 2022 Red Hat Inc. > > # > > # Authors: > > # Fam Zheng <f...@redhat.com> > > @@ -18,7 +18,7 @@ import basevm > > import time > > > > class CentosVM(basevm.BaseVM): > > - name = "centos" > > + name = "centos8s" > > > What's the effect of this ? It feels a little odd to set name to 'centos8s' > here but have this file still called just 'centos' - I assume the 'name' > variable was intended to always match the filename >
Changes the logfile names in ~/.cache/qemu-vm, changes the hostname config in gen_cloud_init_iso(), not much else. You're right, though, I shouldn't change it in one place but not the other ... I'll just leave it as "centos". I felt compelled briefly to indicate it was "the newer, different CentOS" but with the old one being EOL I suppose it's easy enough to infer. --js
