On 6/15/22 12:52, Daniel P. Berrangé wrote:
+ case QEMU_FILE_TYPE_HELPER:+ rel_install_dir = ""; + rel_build_dir = ""; + default_install_dir = default_helper_dir; + break; +
You're replacing ad hoc rules in Akihiko's meson.build with an ad hoc enum + the corresponding "case"s here in qemu_find_file(). There is duplication anyway, in this case between Meson and QEMU (plus QEMU needs to know about two filesystem layouts).
Paolo