On 22/06/2022 18.38, Darren Kenny wrote:
On Wednesday, 2022-06-22 at 12:28:40 -04, Alexander Bulekov wrote:
On 220622 1703, Darren Kenny wrote:
Hi Alex,

This looks good to me, so:

Reviewed-by: Darren Kenny <darren.ke...@oracle.com>

But, if it is at all possible to use Bash glob in a '[[ ... ]]' test
such as:

   if [[ $target == generic-fuzz-* ]]; then

that might read better - but it seems the default is that we don't
assume that, or am I wrong? (This is probably a question for others on
the CC-list)

That sounds good to me. Should we change the script to #!/bin/bash, to
be safe?

If it is acceptable to use the '[[ ... ]]' syntax then you'd definitely
want to ensure that it is bash that is used.

This is not a script that has to run on arbitrary host types, so I think it's OK to change the shebang line to use bash here.

 Thomas


Reply via email to