> On Jun 28, 2022, at 12:01 AM, Cédric Le Goater <c...@kaod.org> wrote: > > On 6/27/22 21:54, Peter Delevoryas wrote: >> Very minor, doesn't effect functionality, but this is supposed to be >> R_I2CC_FUN_CTRL (new-mode, not old-mode). >> Fixes: ba2cccd64e9 ("aspeed: i2c: Add new mode support") >> Signed-off-by: Peter Delevoryas <p...@fb.com> >> --- > > > Can you move this patch at beginning of the series ?
Yep, will-do. > > Reviewed-by: Cédric Le Goater <c...@kaod.org> > > Thanks, > > C. > > > >> hw/i2c/aspeed_i2c.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c >> index 6c8222717f..6abd9b033e 100644 >> --- a/hw/i2c/aspeed_i2c.c >> +++ b/hw/i2c/aspeed_i2c.c >> @@ -552,7 +552,7 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, >> hwaddr offset, >> __func__); >> break; >> } >> - bus->regs[R_I2CD_FUN_CTRL] = value & 0x007dc3ff; >> + bus->regs[R_I2CC_FUN_CTRL] = value & 0x007dc3ff; >> break; >> case A_I2CC_AC_TIMING: >> bus->regs[R_I2CC_AC_TIMING] = value & 0x1ffff0ff; >