On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Tue, Jun 28, 2022 at 06:06:19PM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 5:40 PM Peter Maydell <peter.mayd...@linaro.org> > > wrote: > > > > > > On Tue, 28 Jun 2022 at 12:50, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > I think the main difference is not even in how it works, it's > > > > in what it does. Which is check that ACPI tables are sane. > > > > Who cares about that? Well developers do when they change the > > > > tables. Users really don't because for users we have the expected > > > > tables in tree and we check against these. > > > > > > It wants to build and run a big guest binary blob -- that to me is > > > the main difference. Users don't much care about any of our tests, > > > > perhaps but we do enforce patch submitters to make sure make check > > passes before submitting patches. make check-avocado is not run as > > part of make check, requires considerable disk space to download all > > guest images and hence generally not run by patch submitters. Making > > bits parts of avocado tests almost defeats the purpose of having this > > test at all. > > This proposed biosbits test also involves a considerable download.
I do not think 50 MB is "considerable" . Last time I tried to run avocado tests, my laptop ran out of disk space! > The test is said to be irrelevant for anyone except those working > on a fairly narrow set of QEMU firmware related bits. Well ok that is just a bad argument. You can say the same thing for most qtests. In fact, that is why most qtetes can run directly simply by passing QTEST_QEMU_BINARY in the environment. No need to go through make check. Same with the bits test. It can be run directly. So by the same > rationale we shouldn't impose that burden on everyone working on > QEMU by having it in qtest. So why burden everyone by having bios-tables-test when it only affects acpi/smbios developers? Making it entirely optional, only > downloaded by avocado on demand, for the people who need to run > the tests is best. > > With regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| >