On Thu, Jul 21, 2022 at 09:13:53AM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 21, 2022 at 02:21:18PM +0800, Hogan Wang via wrote: > > There's no way to cancel the current executing dump process, lead to the > > virtual machine manager daemon((e.g. libvirtd) cannot restore the dump > > job after daemon restart. > > > > Add the 'cancelling' and 'cancelled' dump states. > > > > Use 'dump-cancel' qmp command Set the dump state as 'cancelling'. > > The dump process check the 'cancelling' state and break loops. > > The 'cancelled' state mark the dump process cancelled success. > > On the one hand this patch is fairly simple which is obviously > desirable. > > On the other hand though, this feels like it is further re-inventing > the jobs concept. > > IMHO ideally the 'dump' command probably ought to get a 'job-id'
I meant to say an *optional* job-id field, since we need to keep back compat. Possibly we could secretly create a job anyway internally if job-id is omitted, if it makes code easier. > parameter, and integrate with the generic background jobs framework. > This would unlock the ability to use existing commands like > 'job-cancel', 'job-pause', 'job-resume', 'queyr-jobs' to interact > with it. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
