On Thu, Jul 07, 2022 at 05:37:18PM +0100, Daniel P. Berrangé wrote: > The qemu/osdep.h file must be included as the very first header in > all C source files, to ensure its definitions take effect over all > other header files, including system headers. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > tests/style.yml | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/tests/style.yml b/tests/style.yml > index d06c55bb29..6d91ac6115 100644 > --- a/tests/style.yml > +++ b/tests/style.yml > @@ -120,4 +120,26 @@ double_words: > - pc-bios/ > - qemu-options\.hx > - scripts/checkpatch\.pl > - - tests/qtest/arm-cpu-features\.c > \ No newline at end of file > + - tests/qtest/arm-cpu-features\.c
Unrelated to the patch at hand, but a good example of the issue... Can we add a style checker to ensure that text files (including style.yml) end in a trailing newline? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
