Am 26.07.2022 um 21:21 hat Alex Bennée geschrieben: > This bit is unused in actual VirtIO feature negotiation and should > only appear in the vhost-user messages between master and slave. > > [AJB: experiment, this doesn't break the tests but I'm not super > confident of the range of tests] > > Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
I guess the rationale is that this doesn't make a difference because vu_get_features_exec(), which is the only caller of .get_features(), adds the VHOST_USER_F_PROTOCOL_FEATURES bit back before sending a response. Can you please add this to the commit message? > block/export/vhost-user-blk-server.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/export/vhost-user-blk-server.c > b/block/export/vhost-user-blk-server.c > index 3409d9e02e..d31436006d 100644 > --- a/block/export/vhost-user-blk-server.c > +++ b/block/export/vhost-user-blk-server.c > @@ -125,8 +125,7 @@ static uint64_t vu_blk_get_features(VuDev *dev) > 1ull << VIRTIO_BLK_F_MQ | > 1ull << VIRTIO_F_VERSION_1 | > 1ull << VIRTIO_RING_F_INDIRECT_DESC | > - 1ull << VIRTIO_RING_F_EVENT_IDX | > - 1ull << VHOST_USER_F_PROTOCOL_FEATURES; > + 1ull << VIRTIO_RING_F_EVENT_IDX ; This has an extra space before the semicolon. Kevin