Re: [PATCH 07/19] ppc/ppc405: QOM'ify CPC

[Cédric Le Goater]

On 8/3/22 11:14, Daniel Henrique Barboza wrote:
      ppc_dcr_init(env, NULL, NULL);
      /* CPU control */
-    ppc405ep_cpc_init(env, clk_setup, s->sysclk);
+    object_property_set_link(OBJECT(&s->cpc), "cpu", OBJECT(&s->cpu),
+                             &error_abort);
+      if (!qdev_realize(DEVICE(&s->cpc), NULL, errp)) {
+        return;
+    }

This if seems misaligned. Otherwise LGTM.

Indeed.
 
Reviewed-by: Daniel Henrique Barboza <danielhb...@gmail.com>

Thanks,

C.