On 8/4/22 16:31, Jason A. Donenfeld wrote:
I'm still not really keen on adding a knob for this. I understand ARM
has a knob for it for different reasons (better named "dtb-randomness").
If this knob thing is to live on here, maybe it should have
"-randomness" in the name also.
Ok, I just reused your variable name but linuxboot-randomness is fine by
me too.
Rather, let's fix the bug. The code as-is -- going back to the 2016 DTB
addition -- is problematic and needs to be fixed. So let's fix that.
Trying to cover up the problem with a default-off knob just ensures this
stuff will never be made to work right.
It isn't covering up the problem, just providing a workaround
option, should another bug be discovered after release. We
still need to fix current discussed problems of course.
Thanks for the explanation. I don't like adding a knob. But if it's on
by default for the default machine type, then that's a compromise I
could accept.
Yes, in fact this allows enabling the seed even for older machine types
if everything goes fine. And if it doesn't, we only need a one-line
patch to revert the feature, like Michael said. So it's a good thing to
have either way.
The patch was extracted out of my version from last month, but I didn't
--amend the changes needed to make it compile (doh). I incorporated
yours instead and I'll send v2.
Paolo
