On 12/19/2011 08:27 PM, Jordan Justen wrote: > On Sun, Dec 18, 2011 at 02:04, Avi Kivity <a...@redhat.com> wrote: > > On 12/15/2011 11:02 PM, Jordan Justen wrote: > >> I verified that 'info mtree' and 'info qdev' are equivalent for pc-1.0 > >> when using master and with my patches. > >> > >> However, I did discover that v1.0 seems to differ from master for this > >> same test. > >> > > > > That's are fine; pre-memory-API devices don't show up in info mtree. > > > >> @@ -218,7 +221,7 @@ > >> dev-prop: data_iobase = 0x511 > >> irq 0 > >> mmio ffffffffffffffff/0000000000000002 > >> - mmio ffffffffffffffff/0000000000000002 > >> + mmio ffffffffffffffff/0000000000000001 > >> > > > > This one isn't nice. Doesn't affect pc though. > > Thanks Avi. Does this patch series now address your concerns about > qtree/mtree and pc-1.0 with regards to the x86 flash feature? >
It's hard to review, since you move a large function and edit it in the same patch. Usually we separate this into two patches so the changes are visible. The test however indicates that it's probably fine. -- error compiling committee.c: too many arguments to function
